search

usnistgov / oscal-tools

Tools for the OSCAL project
https://pages.nist.gov/oscal-tools/
34 stars 17 forks source link

Configuring calls on SaxonJS to be asynchronous #24

Open wendellpiez opened 2 years ago

wendellpiez commented 2 years ago

Noting here not the 'tocbot' error but the Deprecation warning about SaxonJS directly below it (in the console panel to the right).

image

yet the page code also has

window.onload=function(){SaxonJS.transform({sourceLocation:"../NIST_SP-800-53_rev5_catalog.xml",stylesheetLocation:"catalog-with-profile-ui.sef.json",initialTemplate:"display-catalog"},"async")};

function viewWithProfile(a){for(const c of a){let b=new FileReader;b.onload=function(){SaxonJS.transform({sourceLocation:"../NIST_SP-800-53_rev5_catalog.xml",stylesheetLocation:"catalog-with-profile-ui.sef.json",initialTemplate:"refresh-catalog",stylesheetParams:{profileXML:b.result,fileName:c.name}},"async")},b.readAsText(c)}}

so async is being provided.

Also Firefox does not show the warning. Is this a Chrome issue?

wendellpiez commented 2 years ago

@david-waltermire-nist this is a good example of an Issue that implies maintenance work by a project maintainer (me, in this case) followed by some level of code review.

How should we proceed with these? You need to see both the final pull (merge) with the work done, but also (IMO) you need to see the requirements before the work starts, do you not? at least so you know what to expect, scope of effort etc?

The actual work described in this Issue may have been done, but needs to be checked/confirmed.