usnistgov / oscal-tools

Tools for the OSCAL project
https://pages.nist.gov/oscal-tools/
34 stars 17 forks source link

Repo Contains Obsolete DAP/GA Analytics Code #74

Closed aj-stein-nist closed 1 year ago

aj-stein-nist commented 1 year ago

Describe the bug

I was examining different OSCAL websites to understand why DAP tracking is set correctly in some places and not others, and it appears the old DAP code might be related to use of this repo as the boilerplate for Java projects. I think it was/is manually overridden in some projects but looked here to compare/contrast and thought I would report that as well.

Who is the bug affecting?

NIST staff deploying this websitethat need to host a NIST site (pages.nist.gov or otherwise) and expect to meet requirements to use the current DAP code for pages.nist.gov, or potentially all of CSD/ITL/NIST as deemed appropriate.

What is affected by this bug?

Reporting analytics to DAP as required.

When does this occur?

Consistently.

How do we replicate the issue?

  1. Access the site.
  2. Read code or check events firing off with old DAP UA code

If applicable, add screenshots to help explain your problem.}

Expected behavior (i.e. solution)

Current product UA code (UA-66610693-1) is used for all our sites based of this starter kit repo.

Other Comments

This is related to re-review work from usnistgov/OSCAL#1413 in relation to a few sites to compare and contrast. Low priority but worth calling out.