search

usnistgov / pfhub

The CHiMaD Phase Field Community Website
https://pages.nist.gov/pfhub
Other
49 stars 40 forks source link

Add GitHub ID to default display of table data #1424

Closed wd15 closed 2 years ago

wd15 commented 2 years ago

Address #889

This is only for the notebook version of the comparison pages. All comparison pages will be switched over to notebook views eventually. Not addressing this in JS / CoffeeScript.

Remember to tear down the live site when merging or closing this pull request.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pfhub commented 2 years ago

The new PFHub live website is ready for review.

tkphd commented 2 years ago

In results/benchmark8a.1.ipynb:

[Errno 2] No such file or directory: './data/8a-8a_0.99r-stats.txt' for ./data/8a-8a_0.99r-stats.txt 
[Errno 2] No such file or directory: './data/8a-8a_1.00r-stats.txt' for ./data/8a-8a_1.00r-stats.txt 
[Errno 2] No such file or directory: './data/8a-8a_1.01r-stats.txt' for ./data/8a-8a_1.01r-stats.txt

The free energy and solid interface plots for $r = 0.99 r_0$ are not populated; the rest have at least one curve, despite the error messages.

wd15 commented 2 years ago

In results/benchmark8a.1.ipynb:

[Errno 2] No such file or directory: './data/8a-8a_0.99r-stats.txt' for ./data/8a-8a_0.99r-stats.txt 
[Errno 2] No such file or directory: './data/8a-8a_1.00r-stats.txt' for ./data/8a-8a_1.00r-stats.txt 
[Errno 2] No such file or directory: './data/8a-8a_1.01r-stats.txt' for ./data/8a-8a_1.01r-stats.txt

The free energy and solid interface plots for r=0.99r0 are not populated; the rest have at least one curve, despite the error messages.

Sorry! This should have had WIP on it. I hadn't finished.

pfhub commented 2 years ago

The new PFHub live website is ready for review.

tkphd commented 2 years ago

No worries! The "WIP" is more trouble than it's worth, but it's good to see the "draft" property has been set.

wd15 commented 2 years ago

Ok, this is ready for review now.

wd15 commented 2 years ago

The failure is just from pypi timing out for a download when building the nix environment. This will pass as it passed before I rebased and nothing changed during the rebase.

pfhub commented 2 years ago

The new PFHub live website is ready for review.

pfhub commented 2 years ago

The new PFHub live website is ready for review.