search

usnistgov / pfhub

The CHiMaD Phase Field Community Website
https://pages.nist.gov/pfhub
Other
49 stars 40 forks source link

Generate comparison results from a template with Papermill #1482

Closed wd15 closed 1 year ago

wd15 commented 1 year ago

Things done:

Todo:

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

wd15 commented 1 year ago

@tkphd: this is ready for your review now. Thanks!

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

tkphd commented on 2023-01-27T17:44:06Z ----------------------------------------------------------------

"All result for" -> "All results for", not just in this file.


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

tkphd commented on 2023-01-27T17:44:07Z ----------------------------------------------------------------

  • Recommend that the Timestamp column reflect only the year-month-day, not the hours:minutes:seconds
  • The old interactive table had links to the individual simulation pages as drop-downs. This table appears to have sacrificed that convenient and functional feature. Please add a column containing those links.


pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

wd15 commented 1 year ago

@tkphd, the table should look better now. Please review again. Thanks.

pfhub commented 1 year ago

@wd15, the new version of the PFHub website is available at https://random-cat-1482.surge.sh

wd15 commented 1 year ago

Merging this as the Travis CI failure is fixed in a subsequent PR (easier not to go through the cherry-pick process).

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.