usnistgov / pfhub

The CHiMaD Phase Field Community Website
https://pages.nist.gov/pfhub
Other
49 stars 40 forks source link

Benchmark 1a meta.yaml #1483

Closed mfrichtl closed 1 year ago

mfrichtl commented 1 year ago

Second attempt to add my results for benchmark problem 1a.

pfhub commented 1 year ago

@mfrichtl, the new version of the PFHub website is available at https://random-cat-1483.surge.sh

tkphd commented 1 year ago

Hi @mfrichtl, thanks for your upload! The plots for BM1 assume your CSV file contains a column named "total_energy" that represents the total system free energy, i.e. the integrated functional $$\mathcal{F} = \int\limits_V \left[f(c) + \frac{\kappa}{2}|\nabla c|^2 \right]\mathrm{d}V$$ but your CSV contain a column named "bulk_energy". The number (319.04) looks correct; please rename the column, and maybe the plot will load?

mfrichtl commented 1 year ago

@tkphd -- My "bulk_energy" column is actually just the first term in the integral. I do have a "total_energy" column in my csv that also includes the gradient energy contribution. Do I need to only have "time" and "total_energy" columns for the plot to show up correctly?

tkphd commented 1 year ago

Oh, so you do! My mistake. You can have whatever columns make you happy in the CSV, so long as "time" and "total_energy" are among them, so you're good.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pfhub commented 1 year ago

@mfrichtl, the new version of the PFHub website is available at https://random-cat-1483.surge.sh

wd15 commented 1 year ago

@mfrichtl: looks good now! See here. Also, check that your results looks correct in the efficiency plot.

Edit: let me know in the comments that you're happy with this and then I'll merge.

wd15 commented 1 year ago

@tkphd, @guyer: please check. Thanks.

mfrichtl commented 1 year ago

@wd15 I'm happy with this run and the free energy values I pulled from the simulation. I'll be running more benchmark problems to continue (hopefully) improving my modeling skills.

pfhub commented 1 year ago

Successful teardown of random-cat-1483.surge.sh