Closed wd15 closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
@tkphd, ok, this if finally ready for you to review. Thanks!
View / edit / reply to this conversation on ReviewNB
tkphd commented on 2023-02-23T17:33:33Z ----------------------------------------------------------------
Same complaint about listing the axes as the chart title as the previous PR.
wd15 commented on 2023-02-25T19:50:54Z ----------------------------------------------------------------
Ok, that's the template. I haven't actually re-run the template and it's just used to generate the actual benchmark notebook. See [this](https://random-cat-1485.surge.sh/results/benchmark3a.1.ipynb/) to see how BM3 actually looks.
View / edit / reply to this conversation on ReviewNB
tkphd commented on 2023-02-23T17:33:34Z ----------------------------------------------------------------
Table column order could be improved.
wd15 commented on 2023-02-25T19:53:17Z ----------------------------------------------------------------
Again, that's the template, see here for the rendered template.
View / edit / reply to this conversation on ReviewNB
tkphd commented on 2023-02-23T17:33:33Z ----------------------------------------------------------------
Same complaint about listing the axes as the chart title as the previous PR.
Ok, that's the template. I haven't actually re-run the template and it's just used to generate the actual benchmark notebook. See this to see how BM3 actually looks.
Ok, that's the template. I haven't actually re-run the template and it's just used to generate the actual benchmark notebook. See [this](https://random-cat-1485.surge.sh/results/benchmark3a.1.ipynb/) to see how BM3 actually looks.
View entire conversation on ReviewNB
Again, that's the template, see here for the rendered template.
View entire conversation on ReviewNB
@tkphd, concerns addressed. Please look again. Thanks.
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
On the BM3 spec Overview, what ought to be a paired citation [17, 18]
renders as [[17][takaki2014phase], 18]
.
@wd15, the new version of the PFHub website is available at https://random-cat-1485.surge.sh
Use papermill to generate BM3 results page. In addition:
Todo: