usnistgov / pfhub

The CHiMaD Phase Field Community Website
https://pages.nist.gov/pfhub
Other
49 stars 40 forks source link

Benchmark 1a fix and 1b solution. #1487

Closed mfrichtl closed 1 year ago

mfrichtl commented 1 year ago

I discovered I was not properly tracking total memory usage for my benchmark 1a solution, so I re-ran it and have updated my results. These put my efficiency more in line with other MOOSE results. Sorry for the incorrect reporting in my last PR.

I also included my solution for benchmark 1b. It includes the correct memory usage, so is hopefully good to go.

pfhub commented 1 year ago

@mfrichtl, the new version of the PFHub website is available at https://random-cat-1487.surge.sh

wd15 commented 1 year ago

@mfrictl, thanks for the upload. I have a pull-request waiting for review that addresses some upload issues (#1482). When that's merged, then I can repair and merge any issues on this one. Thanks for your patience!

mfrichtl commented 1 year ago

@wd15 No problem. I'm far from a github guru, but it looks like the only failure I see in the build is related to an external html check routine. Let me know if there's anything that I need to fix on my end.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pfhub commented 1 year ago

@mfrichtl, the new version of the PFHub website is available at https://random-cat-1487.surge.sh

wd15 commented 1 year ago

@mfrichtl: please take a look and check things. It looks good to me.

1a: https://random-cat-1487.surge.sh/results/benchmark1a.1.ipynb/ 1b: https://random-cat-1487.surge.sh/results/benchmark1b.1.ipynb/

mfrichtl commented 1 year ago

@wd15 I agree. I think it looks good. Please let me know if there's anything I can do to address the build failure issue on my side.

guyer commented 1 year ago

Hard to know what I'm looking at. The notebooks look fine, but the files changed are dominated by things that @mfrichtl didn't do, AFAICT.