usnistgov / pfhub

The CHiMaD Phase Field Community Website
https://pages.nist.gov/pfhub
Other
49 stars 40 forks source link

Benchmark 2 misattributes concentration gradient energy term #1495

Open guyer opened 1 year ago

guyer commented 1 year ago

As reported by @daubners, the free energy in Benchmark 2 includes a term " $\frac{\kappa_{c}}{2}|\nabla c|^{2}$ " and says it is based on Ref. [ZHU] (and, indirectly, on Ref. [KKS]) and on Ref. [WBM]. None of these sources include a gradient energy term in concentration, although Ref. [WBM] does remark "a more general model might also include contributions due to the gradients of the other thermodynamic variables".

This term isn't "wrong", but it shouldn't be attributed to [ZHU] or [WBM].

Related: after Eq. (7), there is a typo in the coefficients: " $kc = k\phi = 3$ " should read " $\kappac = \kappa\phi = 3$. "

Note: these issues carry over from the original benchmark paper.

wd15 commented 1 year ago

Can I just implement what you've suggested? Would anyone require a discussion about this?

guyer commented 1 year ago

I don't know that it needs discussion; just a question of how to phrase it. Something like

the free energy of the system is based on a more general formulation (including concentration gradient energy) of that presented in Ref. ZHU...

daubners commented 1 year ago

I guess this would be the correct reference https://doi.org/10.1103/PhysRevE.47.1893

guyer commented 1 year ago

Agreed

guyer commented 1 year ago

...along with [ZHU] for the multi-phase