usnistgov / pfhub

The CHiMaD Phase Field Community Website
https://pages.nist.gov/pfhub
Other
49 stars 40 forks source link

Cleaner code generation for MMS source term #1504

Closed tkphd closed 1 year ago

tkphd commented 1 year ago

Replaces SymPy code for deriving the MMS source term to more closely follow @stvdwtt's derivation, producing more apparent agreement and tidier expressions.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pfhub commented 1 year ago

@tkphd, the new version of the PFHub website is available at https://random-cat-1504.surge.sh

wd15 commented 1 year ago

I can't fix this as my environments don't seem to have sympy

wd15 commented 1 year ago

Also, https://random-cat-1504.surge.sh/benchmarks/benchmark7.ipynb/#Feedback seems to have broken markdown for the links. I think you just need to reexcute the cell and rebuild the html. I can do that if you sort the issue above.

pfhub commented 1 year ago

@tkphd, the new version of the PFHub website is available at https://random-cat-1504.surge.sh

pfhub commented 1 year ago

@tkphd, the new version of the PFHub website is available at https://random-cat-1504.surge.sh

pfhub commented 1 year ago

@tkphd, the new version of the PFHub website is available at https://random-cat-1504.surge.sh

tkphd commented 1 year ago

The links are still broken, but the math is better. Thanks!

pfhub commented 1 year ago

@tkphd, the new version of the PFHub website is available at https://random-cat-1504.surge.sh