Logging implementation - Githubissues

jat255 commented 5 years ago

Resolves #22

Hi Charlie, I've implemented a swap from print statements to logging, as it provides a bit more flexibility in using the library externally. I also made some PEP8 changes at the request of my IDE. The tests all still pass and the coverage has remained the same.

If you're alright with this change, it would be great if you could trigger a minor release to pypi, since we're hoping to rely on this change for some additions into HyperSpy.

jat255 commented 5 years ago

FYI, @AndrewHerzing and I are running a HyperSpy tutorial next week if you're interested

CCampJr commented 5 years ago

@jat255 @AndrewHerzing

For the average Python user, they definitely want easy access to verbose output. I guess I have 2 options:

Add notes and examples of logger output to stdev stream
Keep verbose tied to print(), add a log_verbose param, and duplicate str's b/w print and logging -- so for your app you'd use the logging, setting log_verbose=True, and verbose=False.

Thus far I've merged your PR into my personal 0.3.X fork and am working on the following:

[x] Add logging output to stream stdout in main example
[x] Add logging output to stream stdout in Demo Jupyter NB
[x] Add note about logging in documentation so users will know how to access the outputs

I'm not in love with average users needing to mess with the logger to see the basic outputs, but I want to make sure PyMCR can quickly get compatibalized with your work.

Thoughts?

usnistgov / pyMCR

Logging implementation #23