usnistgov / pyMCR

pyMCR: Multivariate Curve Resolution for Python

https://pages.nist.gov/pyMCR

Other

80 stars 27 forks source link

Improve documentation of example and correction of a mistake in README #4

Closed charlesll closed 6 years ago

charlesll commented 6 years ago

Hi,

I just improved a few points in the example to make it more readable.

I also corrected a mistake in the README, and added a bit more information on tested versions of packages.

The new interoperability with sklearn is a very nice feature!

Best, Charles.

codecov[bot] commented 6 years ago

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files           9        9           
  Lines         372      372           
=======================================
  Hits          355      355           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5eec6c6...efa82c3. Read the comment docs.

CCampJr commented 6 years ago

@charlesll , thank you very much for the contribution.

I merged your PR into the 0.2.X branch -- it will become version 0.2.1
I added your name and email to the end of the README as a contributor -- I assume that's cool

All tests are passing and everything looks good, so I'll merge with master shortly.

charlesll commented 6 years ago

Good, thanks!

I will add other examples in the near future!