usnistgov / pyMCR

pyMCR: Multivariate Curve Resolution for Python
https://pages.nist.gov/pyMCR
Other
80 stars 27 forks source link

Add two indicators to determine the ranks #7

Closed sshojiro closed 6 years ago

sshojiro commented 6 years ago

This PR (derived from 0.3.X) includes following features:

  1. IND (INDicator) and ROD (ratio of derivatives) are added
  2. Example notebook for the indicators is added
  3. IND is computed with only numpy svd module, aiming at a reduction of dependency
codecov[bot] commented 6 years ago

Codecov Report

Merging #7 into 0.3.X will decrease coverage by 0.8%. The diff coverage is 87.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0.3.X       #7      +/-   ##
==========================================
- Coverage   98.39%   97.58%   -0.81%     
==========================================
  Files           9       13       +4     
  Lines        1306     1407     +101     
==========================================
+ Hits         1285     1373      +88     
- Misses         21       34      +13
Impacted Files Coverage Δ
pymcr/metrics.py 100% <ø> (ø) :arrow_up:
pymcr/tests/test_condition.py 100% <100%> (ø)
pymcr/tests/test_rank.py 100% <100%> (ø)
pymcr/condition.py 100% <100%> (ø)
pymcr/rank.py 59.37% <59.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dffc120...e043896. Read the comment docs.

CCampJr commented 6 years ago

Updates:

Still needing to be done:

CCampJr commented 6 years ago

Hi @sshojiro ,

Just checking if you've seen the alterations I made. It should give the same results as what you first prepared.

Thanks!

sshojiro commented 6 years ago

@CCampJr Well, I've found a mistake in IND definition. I'm working on an implementation of IND function and test for both ind and rod now.

I've modified the docstring into ind and rod. Sorry for this late response.