usnistgov / teqp

A highly efficient, flexible, and accurate implementation of thermodynamic EOS powered by automatic differentiation
https://pages.nist.gov/teqp-docs/en/latest/index.html
Other
49 stars 12 forks source link

Expose ReducingFunctions to public interface for all applicable EOS models #158

Open Matthew-Boyd opened 2 weeks ago

Matthew-Boyd commented 2 weeks ago

This is missing for at least the multifluid-association and multifluid-activity EOS models. It is present for the multifluid model, for example.

An alternative and preferred approach would be to add the reducing functions (for temperature and density) to the AbstractModel class.

ianhbell commented 2 weeks ago

I think I will go for exposing the reducing function outputs directly here, and add the necessary pass through functions