search

usnistgov / trec_eval

Evaluation software used in the Text Retrieval Conference
232 stars 49 forks source link

Fix undefined behavior #16

Closed bgamari closed 5 years ago

bgamari commented 6 years ago

Various te_num_* variables were defined as int, but then declared elsewhere as long. This is undefined behavior in C, which may sometimes result in segmentation faults (as observed in #14).

akashdeep-singh commented 5 years ago

Also, this and #12 are identical. Someone needs to sort this out.

bgamari commented 5 years ago

Yes, I would really appreciate it if someone could merge this.

isoboroff commented 5 years ago

I apologize for not keeping up. I will get these merged in the next few days.

carlaiau commented 4 years ago

Seconding @searchivarius last message, please @isoboroff.

I was hunting around for quite a while trying to figure out the segmentation fault.

After cloning the master, and compiling with GCC 7.4 on Ubuntu 19.04, fails long test but passes short test,

isoboroff commented 4 years ago

I am going to try to resolve/merge fixes for the couple of outstanding issues and kick out a release.

isoboroff commented 4 years ago

trec_eval 9.0.7 is out, a tarball is on the releases page, and I updated the TREC website.

carlaiau commented 4 years ago

@isoboroff Great stuff thank you so much