search

usnistgov / trec_eval

Evaluation software used in the Text Retrieval Conference
235 stars 48 forks source link

Windows builds on GHA #44

Closed cmacdonald closed 9 months ago

cmacdonald commented 9 months ago

Ian,

As requested...

I'm not sure how a native Windows build got into the Github Actions file. I did have a fork that attempted this (https://github.com/cmacdonald/trec_eval/tree/windows_msvc), but that seemingly wasnt merged.

I've redone some of the work from that branch in this fork, esp using git submodules rather than copying of files. It now builds, but the test batch file doesnt run - I'll look at that again soon. I'm putting the PR so you can start to have a look at this. I'll figure out what is wrong with the test case in the near future, before merging.

Craig

cmacdonald commented 9 months ago

Ok, this now appears to build and test out ok. Over to you for review @isoboroff. Seems mostly to have been about identifying and copying over changes from that other branch.

isoboroff commented 9 months ago

If only C compilers had like a switch to compile against what C was in 1984.

cmacdonald commented 9 months ago

Did not know Windows didn't have open(2).

I think it does, but you can't use the filehandle in exactly the same way - the lseek or something else in that expression fails.

Good we got this merged :-) We should make a Github Action that can build the windows .exe file and put it somewhere accessible to the general public.