Open drummerboy46 opened 8 months ago
It seems that this repo is not the same codebase as is used for the NuGet package, which lists a Current version: 1.0.2 (Updated Jan 19, 2024) whereas this repo has not been updated for 4 years. Which makes the information on the Umbraco Marketplace and on the NuGet site inaccurate. Unfortunately. I installed that NuGet package and can't even get the section to show up, so ...
It seems this is an updated codebase: https://github.com/huwred/UmbracoTagManager
@drummerboy46 - Come on over to https://github.com/huwred/UmbracoTagManager and make your fixes. Huw is merging in PRs.
Hi, I am checking with my developers what is wrong. We released the new tagmanager last month for latest version last month, V7 and V8 also still exist. V13 information on marketplace should be accurate
oh, and due to some stupid notification issue we didn't receive the latest issue here, that is why my team did not respond....sorry about that, contributions to our package are more than welcome if you want to share! Cheers, Melvin
@hfloyd @drummerboy46 too little, too late... but indeed the source code was not pushed. We are working on that now.
@drummerboy46 could you share the UI bugs? We will fix them on this version as well
Hi @melvinvanrookhuizen I'd suggest your team clone the above referenced fork and compare it to your current v10+version to make sure that any issues have been resolved.
Hi @drummerboy46,
Thank you for bringing these UI bugs to our attention. Could you please provide more details or specific steps to replicate these issues? With that information, we'll be able to address them more effectively.
Additionally, regarding the interface issue, we've made updates in TagManager 1.0.2 which might have resolved the problem you encountered. Have you had a chance to try this updated version?
Also, I wanted to inform you that the source code is now available
We're using Azure DevOps for version control, so it's on us that we didn't make the source code available. We apologize for the inconvenience.
Regards,
@drummerboy46 - Come on over to https://github.com/huwred/UmbracoTagManager and make your fixes. Huw is merging in PRs.
@drummerboy46 - Come on over to https://github.com/huwred/UmbracoTagManager and make your fixes. Huw is merging in PRs.
@hfloyd - I've cloned the source, and actually prefer huws version. Crucially I need a "read-only" tag picker provided in this repo, but upon testing, I found the pre-values confusing and the entire datatype didn't really work as I expected. I've done some work to improve it (most simplify the angular/pre-value code and would like to create a pull request. I have compiled it against Umbraco 13 libs, is this ok? Finally will this version be submitted to nuget as its not currently available publicly.
@drummerboy46 I'm not in charge of either of these repos, so I'd suggest you direct your questions to Huw or Melvin directly.
I've only used Huw's version because that was the codebase available when I needed to fix something. I compiled a NuGet package locally and am using that. I haven't looked at Melvin's newly-uploaded sourcecode, so I can't compare.
@hfloyd @drummerboy46 @huwred and anyone else :-) thanks for the comments, we have updated the source, and are open to contributions and suggestions. We will make sure to update all files ;-)
@hfloyd @drummerboy46 @huwred and anyone else :-) thanks for the comments, we have updated the source, and are open to contributions and suggestions. We will make sure to update all files ;-)
@melvinvanrookhuizen thanks for the update, having reviewed both versions, i've decided initially to base my changes on huws version as it included a couple of useful additions...
The code overall seems like a mashup of older JS/Angular so i'm in the process of updating as much as I can to the newer UmbracoUI.
Please bear with me, when I'm done i'll clone your library and merge the changes. Fingers crossed you'll like it and accept a pull request.
All the best Martin
Thanks for the update, @drummerboy46 ! Once we receive the pull request, we'll review and merge it accordingly. Appreciate your collaboration!
I just installed the nuget package "TagManager by Usome" versiopn 1.0.3 as that is what Umbraco Marketplace said to sintall but when I whent into my backoffice there is no "TagManager" tab and I am on Umb13. I could not really follow what is going on in this thread so I am confused as to if this package is being matianined, did I install the right pacakge, or should I be getting the package from somwhere else?
@Eaglef90 I did a quick check to trace the issue you reported. The version you installed still working fine. Only the thing missing is auto assign "Tagmanager" section to the user group permission. For now you can add it manually from users tab. We will be releasing another version with the improvements.
Added the permissions I was able to see it now but doing anything from the tag editor breaks the entire data set. I will open a bug for this.
@Eaglef90
Thanks for bringing this to our attention! We've fixed the issue by implementing a solution that preserves data integrity when changing tag names in Umbraco 13. Now, properties like text-boxes and RTEs retain their values, preventing any loss of data
Please make sure to use the latest version of the [TagManager.1.0.4,] (https://www.nuget.org/packages/TagManager/1.0.4) as these fixes have been implemented there.
If you have any further questions or encounter additional issues, feel free to reach out.
Best Regards,
@hfloyd @huwred @melvinvanrookhuizen can you please take a look at the following feature request I've made in the Umbraco Source
https://github.com/umbraco/Umbraco-CMS/discussions/15840
"Tagging" or the act of it IMHO is to do with "relational" taxonomy. For example, the ability to display a bunch documents on a website based on their taxonomy tags and filter by these tags is an important part of any CMS system. So i've suggested a number of API improvements as well as showing some changes I've made so far in TagManager.
Changing TagManager has been quite a frustrating process for me, mainly because I didn't fully understand Tag APIs in Umbraco, they essentially limit you to what's already applied to a given content property (the property editor does this too) and I feel it makes uptake of the Tag property a weak option for taxonomy picking as a mechanic to document relationships by Specialism, Topic, Region, Expert etc etc.
You (and the Umbraco team) may not agree with my take on this, but the only other alternative is using un-templated content nodes and an MNTP, i'm sure most people use this method, which isn't really the Umbraco way any more!
@hfloyd @huwred @melvinvanrookhuizen - After spending a lot of time on this project I've decided to put up my own repo and publish a nuget package. The code has been significantly re-written/refactored with parameter safe SQL inside a set of data repositories and a functionally complete UI.
My repo is available here... https://github.com/drummerboy46/Umbraco-Tag-Manager
My nuget package is here... https://www.nuget.org/packages/Our.Umbraco.Community.TagManager
Will the new sourcecode be made available?
I've found 2 UI bugs to fix!