uspgamedev / luasteam

Bindings to connect lua with Steam API
https://luasteam.readthedocs.io/en/stable/
MIT License
116 stars 19 forks source link

Many improvements #2

Closed yancouto closed 5 years ago

yancouto commented 5 years ago

I'll list everything that changed:

rilifon commented 5 years ago

We should start to documentate which fucntions we have already implemented from Steam's API, and which "module" they are from (such as 'userStats'). How about we use github's wiki for this?

yancouto commented 5 years ago

Yes, I have tested all new functions, and MarvInc works with the renamed functions (here). Other than that, I haven't individually tested the old functions, but they were just renamed in this PR.

If you want to keep track of which functions are already implemented and which are missing, an issue with a task list is best. Documenting the lua library is another thing.

rilifon commented 5 years ago

If you want to keep track of which functions are already implemented and which are missing, an issue with a task list is best. I mean just detail which lua functions we have implemented so far (and ideally how to use them so we could just use our own documentation instead of going to Steam's)

yancouto commented 5 years ago

Yes, documenting the library would be great, but it's not on the scope of this PR.

henriquegemignani commented 5 years ago

I prefer merging this directly to master. I don't think "master is only for releases" is a good strategy. Tags are meant for releases, not master.

yancouto commented 5 years ago

Will start sending PRs to master once we have some proper explanations on README.