search

uspgamedev / luasteam

Bindings to connect lua with Steam API
https://luasteam.readthedocs.io/en/stable/
MIT License
134 stars 25 forks source link

Implement ISteamInput #23

Closed Davidobot closed 3 years ago

Davidobot commented 3 years ago

An implementation of the ISteamInput Interface.

Docs written and ready for full review and merging.

Davidobot commented 3 years ago

Wrote the docs so it's ready for a full review! 🎉

Davidobot commented 3 years ago

Thanks, @yancouto!

I think I addressed everything you mentioned.

Did you test any of these in an actual game? If so, let me know, will make it easier to review.

Tested a few of them, but limited to the vibration functions, getMotionData, showBindingPanel, and getConnectedControllers. They all work as intended!

Davidobot commented 3 years ago

Sorry for making you repeat yourself with certain comments.

Everything should be addressed now :) Thanks!

Davidobot commented 3 years ago

I think this is the only module we needed for our project that wasn't already implemented, so I don't think I'll be pushing any more PRs any time soon.

Thanks for the review!

yancouto commented 3 years ago

This was just release on 1.2.0. Thanks @Davidobot !