search

uspgamedev / luasteam

Bindings to connect lua with Steam API
https://luasteam.readthedocs.io/en/stable/
MIT License
129 stars 23 forks source link

support inviting to game over steam friends #33

Closed hylje closed 8 months ago

hylje commented 1 year ago

resolves https://github.com/uspgamedev/luasteam/issues/29

yancouto commented 8 months ago

This looks good. Was this tested in some game, though?

hylje commented 8 months ago

Rich presence joining works great on a game lobby that we have tested in practice with my friend that works on his game, the command line parsing function has not been explicitly tested but I keep nagging him about implementing it

hylje commented 8 months ago

rebased against latest upstream master

hylje commented 8 months ago

I'll rebase again, sec

ed. ah force push on upstream master made my fork master diverge, I'll let you do your thing first

yancouto commented 8 months ago

Done, I landed this.

BTW I changed the name of the key in the connect callback from connectString to connect.

I also changed some docs. In the future, try to stick as close as possible to the steam docs, mostly copying and rephrasing them. Also, careful with the trailing whitespaces.

Thank you for the changes!! Sorry my review took so long.

Closing as this was merged, though it didn't seem to auto-detect.