usrl-uofsc / stag_ros

A ROS package for the Stable Fiducial Marker System
45 stars 16 forks source link

Fix more mismatched delete operators (cherry-pick from upstream stag) #20

Closed meyerj closed 1 year ago

meyerj commented 1 year ago

I missed that one in #19 and you were too fast with merging it ;-)

It is a bit more hidden, because A is allocated within SortAnchorsByGradValue() here, and the compiler (Clang) does not emit a warning:

https://github.com/usrl-uofsc/stag_ros/blob/6e6c02158d72c4bdcf82f63d85031264dd635822/src/stag/ED/EDInternals.cpp#L178

https://github.com/usrl-uofsc/stag_ros/blob/6e6c02158d72c4bdcf82f63d85031264dd635822/src/stag/ED/EDInternals.cpp#L866

MikeK4y commented 1 year ago

These are all in the core STag code, not part of the ROS wrapper and I see there were recently a couple of similar pull requests there so we should probably apply these as well before merging

https://github.com/bbenligiray/stag/pull/31 https://github.com/bbenligiray/stag/pull/32

meyerj commented 1 year ago

These are all in the core STag code, not part of the ROS wrapper and I see there were recently a couple of similar pull requests there so we should probably apply these as well before merging

bbenligiray/stag#31 bbenligiray/stag#32

I cherry-picked them both to here. https://github.com/bbenligiray/stag/pull/31 was already partially applied in #19.

MikeK4y commented 1 year ago

There were quite a few instances after all! Great catch