search

usrlocalben / pydux

Pydux = Python + Redux
MIT License
120 stars 12 forks source link

WIP: Copy tests from ebrakke/python-redux #7

Closed kasbah closed 7 years ago

kasbah commented 7 years ago

I copied the tests over from python-redux. These are writen for Python 3.4 so can be run with:

python3 -m unittest discover

As of now, they error with: 

ImportError: cannot import name 'bind_action_creators'

I guess this is not implemented. Would love some insight into this and whether it is viable to copy these tests over.

kasbah commented 7 years ago

Ok, I removed the bind_action_creators test and made some tweaks and these run now. Still getting 12 failures/errors but those seem a bit harder to figure out. 

Ran 40 tests in 0.019s

FAILED (failures=9, errors=3)
kasbah commented 7 years ago

Looks like the initial problems are since the tests expect use of logging. How do you want to approach this? Should we add logging or handle this in a different way?

usrlocalben commented 7 years ago

I checked out your branch and started on it locally.

I removed the tests that were spying on the logger and fixed a few bugs and translation inconsistencies.

....................................
----------------------------------------------------------------------
Ran 36 tests in 0.011s

OK

Unless you have an objection, I'll start with your branch, add a few commits from what I have here, and then merge to master.

kasbah commented 7 years ago

Sounds great!

kasbah commented 7 years ago

Is 0.2.0 going to go up on PyPI soon?

usrlocalben commented 7 years ago

pypi is now at 0.2.0