ustajan / grasshopper

GNU General Public License v3.0
6 stars 4 forks source link

CMake Build #14

Closed yacubus-bishcus closed 3 years ago

yacubus-bishcus commented 3 years ago

Areg. I added CMakeLists.txt for the CMake Build. I've tested it on my computer and it seems to work. Other Files I Edited: README.md to include instructions for cmake build Edits in PrimaryGenerator and Analysis to git rid of integer type sign warnings... this is just a minor change that makes the integer type more specific to unsigned int.

A Few Things to Note: For CMake builds the CMake version must be atleast 3.17... this is on the NSE Cluster and Engaging cluster and can be loaded via "module load cmake/3.17" in the user's bashrc. For Debugging it could be useful to show all warnings. This is achieved by adding the Cmake flag -DSHOW_WARNINGS.

/home/jbickus/TEST_GRASSHOPPER/grasshopper/src/Analysis.cc:433:16: warning: variable ‘aWaveLength’ set but not used [-Wunused-but-set-variable] 433 | Double_t aWaveLength = 0.0; // will be in [nanometer] I checked the warning that I see in your Analysis.cc file. I can't get rid of the warning but it can just be ignored.