search

ustaxcourt / ef-cms

An Electronic Filing / Case Management System.
https://dawson.ustaxcourt.gov/
Other
88 stars 47 forks source link

10001 (and 10002 and 10003) Design Debt Updates #5373

Closed Mwindo closed 2 months ago

Mwindo commented 2 months ago

The validation in the original PR for 10001 et al. correctly caught that corrupt-pdf is corrupt in the Cypress test but did not catch it outside of Cypress.

This PR thus does two things:

  1. Ensures that our PDF file uploads within Cypress mimic the file uploads outside of Cypress by specifying that the upload is in binary format.
  2. Implements an unfortunate solution--but as far as I can tell the only viable solution, unless we use something other than pdfjs--to catch corrupt but not fully invalid PDFs.
Mwindo commented 2 months ago

This approach is unnecessary. I will open a better PR.