search

ustulation / p2p

NAT Traversal techniques for p2p communication
BSD 3-Clause "New" or "Revised" License
137 stars 26 forks source link

MAID-3246: use safe crypto #92

Closed povilasb closed 5 years ago

povilasb commented 5 years ago

Replace rust_sodium with safe_crypto.

ustulation commented 5 years ago

We proabably don't need everything in this PR anymore. Socket-collections can now be configured to encrypt/decrypt all wire data so we should be good if users of that crate (like this one) can simply configure it that way.

povilasb commented 5 years ago

I was planning to build socket-collection with encryption integration into p2p based on this PR. Otherwise I will have to redo quite a few changes: e.g. replace rust_dosium with safe_crypto types in code/examples/tests...

povilasb commented 5 years ago

I would highly advise to review and merge this PR.

  1. It replaces rust_sodium with safe_crypto which will have to be done in the near future anyway.
  2. These are safe mechanical changes with a low chance of breaking anything.
  3. These changes touch most parts of the code base. That means if anything changes in p2p I have to rebase this PR and that is a lot of work again. Also, consider point 1 in this case.