search

ustwo / vip-demo-swift

Swift sample app demonstrating VIP architecture for iOS.
MIT License
49 stars 15 forks source link

Updates for Xcode 9 and Swift 4.1 #12

Closed madhikarma closed 6 years ago

madhikarma commented 6 years ago

Description

Updates

codecov-io commented 6 years ago

Codecov Report

Merging #12 into master will increase coverage by 9.4%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
+ Coverage   82.08%   91.48%   +9.4%     
=========================================
  Files          34       47     +13     
  Lines         815     1903   +1088     
=========================================
+ Hits          669     1741   +1072     
- Misses        146      162     +16
Impacted Files Coverage Δ
...mo/Sources/Artist Detail/Router/ArtistRouter.swift 100% <ø> (ø) :arrow_up:
...rces/Artist Detail/View/ArtistViewController.swift 82.92% <100%> (+1.21%) :arrow_up:
...DemoTests/Artists/ArtistsViewControllerTests.swift 97.32% <100%> (ø)
...o/Sources/Artists/Presenter/ArtistsPresenter.swift 100% <100%> (ø) :arrow_up:
VIPDemo/Sources/Artists/Router/ArtistsRouter.swift 100% <100%> (ø) :arrow_up:
VIPDemo/Sources/Shared/Model/Album.swift 92.85% <100%> (ø) :arrow_up:
VIPDemoTests/Artists/ArtistsRouterTests.swift 93.75% <100%> (ø)
...IPDemo/Sources/Artists/Model/ArtistsAPIStore.swift 89.18% <100%> (+2.7%) :arrow_up:
...o/Sources/Artist Detail/Model/AlbumsAPIStore.swift 94.59% <100%> (ø) :arrow_up:
VIPDemo/Sources/Shared/Model/Artist.swift 93.33% <100%> (ø) :arrow_up:
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cdffa2...c2594ea. Read the comment docs.