usuiat / Zoomable

Jetpack Compose library that enables contents zooming with pinch gesture.
https://usuiat.github.io/Zoomable/
Apache License 2.0
408 stars 20 forks source link

Resolve gesture conflict with Pager #143

Closed usuiat closed 9 months ago

usuiat commented 9 months ago

Issue

Related PR

Overview

This PR resolve gesture conflict between Modifier.zoomable and the parent component such like HorizontalPager.

Description

To resolve Issue #93, I previously merged PR #125, which implemented NestedScrollConnection in Modifier.zoomable. But it required the user to change Pager's pageNestedScrollConnection option.

However, I found a better way:

The user does not need to make any changes to the Pager implementation.

In this PR, I implemented the way above, and reverted the change of #125.