search

usuiat / Zoomable

Jetpack Compose library that enables contents zooming with pinch gesture.
https://usuiat.github.io/Zoomable/
Apache License 2.0
325 stars 15 forks source link

Min/Max scale #193

Closed T8RIN closed 3 months ago

T8RIN commented 3 months ago

is it possible to Expose maxScale property and also add minScale?

usuiat commented 3 months ago

@T8RIN Thank you for the issue and the pull request. I have two requests.

1) Can you tell me why minScale and maxScale are needed? I made these properties private because I could not imagine a use case where the properties would be used externally. If you have a specific use case in mind, please let me know.

2) Please make one PullRequest for one Issue.

T8RIN commented 3 months ago

I want to create custom double tap handler so it will work as tri state one, but there we really need max scale and minscale to calculate center one

usuiat commented 3 months ago

Thanks, I understand. I agree to change maxScale to public. However, it is difficult to change minScale to public. This is because zoomable is implemented with the assumption that minScale=1. Allowing arbitrary minScale would require significant implementation changes.

T8RIN commented 3 months ago

Okay