search

usuiat / Zoomable

Jetpack Compose library that enables contents zooming with pinch gesture.
https://usuiat.github.io/Zoomable/
Apache License 2.0
375 stars 20 forks source link

This library exposes a BuildConfig in its public API. Consider disabling it. #98

Closed StylianosGakis closed 1 year ago

StylianosGakis commented 1 year ago

https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/BuildFeatures#buildconfig

usuiat commented 1 year ago

@StylianosGakis Thank you for creating an issue. I am not very familiar with buildconfig, so could you confirm the change?

StylianosGakis commented 1 year ago

Ever since AGP 8.0 (I think) the field android.defaults.buildfeatures.buildconfig was flipped to by default be false anyway. So yeah your fix must be enough as far as I am aware. Simply check in a sample project which imports this library that the BuildConfig is in fact not being generated and it should be all good.

usuiat commented 1 year ago

Fixed by #99