ususdei / qute-keepassxc

Qutebrowser userscript to fetch credentials from KeepassXC password database
MIT License
54 stars 10 forks source link

fix(get_logins): my_privkey -> ep_privkey #2

Closed qhga closed 4 years ago

qhga commented 4 years ago

the supplied public key in the get_logins function should be the new associated pulbic key (happens in line 105-112).

ususdei commented 4 years ago

Thanks @toerd for digging into this and sorry @aearil, I totally missed your report :-/

So I did some research yesterday and it seems keepassxreboot/keepassxc#3480 was the culprit. In the usecase with only a single database, which is the only one I ever used myself, the key given in get_logins was never checked against the stored associations of the database in the keepassxc versions before. Now it is done in every case which led to no database getting searched and therefore no entry getting found. Just to be clear: This was totally a mistake on my side. Of course it doesn't make any sense to use a temporary key for any identification. This should never have worked. Thus #2 is indeed the correct fix.

aearil commented 4 years ago

Thank you !! It seems to work perfectly for me here. You just made my life that little bit easier :)