search

uswds / public-sans

A strong, neutral, principles-driven, open source typeface for text or display
https://public-sans.digital.gov/
Other
4.45k stars 102 forks source link

Include Docker #213

Closed gscottqueen closed 2 years ago

gscottqueen commented 3 years ago

Closes https://github.com/uswds/public-sans/issues/214

This works to include a docker container that allows maintainers to execute our build-font.sh script inside a controlled env that is not dependent on the current user operating system.

To test: npm run build

scottqueen-bixal commented 3 years ago

@mejiaj when you get a chance, can you please try to run the build?

scottqueen-bixal commented 3 years ago

@mejiaj this is updated to build the image with python and only include the dependencies we need rather than relying on HomeBrew.

mejiaj commented 3 years ago

@scottqueen-bixal

First run seems successful. It did seem to take unusually long (8m30s). Second run took 8m43s oddly enough.

I think that's OK if it's consistent. Great work!

Sidenote: I got this error message when I tried to preview the fonts on Windows:

image

But that's because it's in the linux subsystem. Works fine if you drag it to your desktop.

thisisdano commented 2 years ago 
└─ ░██████╗██╗░░░██╗░█████╗░░█████╗░███████╗░██████╗░██████╗██╗
   ██╔════╝██║░░░██║██╔══██╗██╔══██╗██╔════╝██╔════╝██╔════╝██║
   ╚█████╗░██║░░░██║██║░░╚═╝██║░░╚═╝█████╗░░╚█████╗░╚█████╗░██║
   ░╚═══██╗██║░░░██║██║░░██╗██║░░██╗██╔══╝░░░╚═══██╗░╚═══██╗╚═╝
   ██████╔╝╚██████╔╝╚█████╔╝╚█████╔╝███████╗██████╔╝██████╔╝██╗
   ╚═════╝░░╚═════╝░░╚════╝░░╚════╝░╚══════╝╚═════╝░╚═════╝░╚═╝

Worked perfectly, once I installed Docker.

thisisdano commented 2 years ago

Nice work, a huge improvement