uswds / uswds-for-designers

USWDS visual design and UX assets
https://designsystem.digital.gov
Other
182 stars 43 forks source link

Update design assets #54

Closed thisisdano closed 5 years ago

thisisdano commented 5 years ago

A brand new set of design files for Sketch. 💎 This builds upon a lot of the smart ideas in https://github.com/uswds/uswds-for-designers/pull/40 and adds a few new tricks of its own. 🚀

maya commented 5 years ago

Does this work supersede #40?

thisisdano commented 5 years ago

Yes, but I will take a look at that work and see if there's anything I can implement in the new system. Also, I clarified this issue to make it clear it's a WIP. Don't merge yet.

thisisdano commented 5 years ago

De-WIPped! 🍨

maya commented 5 years ago

Is the intention that the default font is Public Sans, not Source Sans Pro and Merriweather?

A few instances where the text breaks:

Screen Shot 2019-04-03 at 9 58 12 AM Screen Shot 2019-04-03 at 10 04 11 AM

Where are the page templates? Or are we not including them?

maya commented 5 years ago

Maybe it's b/c I don have the most recent version of Public Sans... will try to uninstall and reinstall.

maya commented 5 years ago

Nope, still seeing the same issue after uninstalling and reinstalling Public Sans from the font files provided.

thisisdano commented 5 years ago

Hm — I don't see those breaks but I can try and fix. Also, I didn't have page templates in the file I was working from... I wonder why?

thisisdano commented 5 years ago

Also, I left a note in the _How to use the stickersheets but I've kept everything in Public Sans rn because of some of the complexity around font normalization in Sketch

thisisdano commented 5 years ago

@maya I've made some progress toward font switching, but we won't have a complete solution just yet. Once you can give it another once-over for weird button stuff, it should be ready to merge.

maya commented 5 years ago

@thisisdano how are the zip files generated for https://v2.designsystem.digital.gov/download/ again?

maya commented 5 years ago

I see they live here: https://github.com/uswds/uswds-site/tree/v2/files and need to be updated. Are we still providing the other design files or are they being deprecated?

thisisdano commented 5 years ago

I'll have to manually make the zip files and add them to uswds-site — the other design files are still in the 1.x state. I don't think they're officially deprecated yet, but I don't have a good sense of priorities yet when it comes to formats other than Sketch.