uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
194 stars 148 forks source link

508 Error with Combo Box on USAJOBS #1359

Closed Julie-Jackson closed 2 years ago

Julie-Jackson commented 2 years ago

Title line template: [Title]: Brief description

USAJOBS is receiving a 508 error when using the combo box in the design systemhttps://designsystem.digital.gov/components/combo-box/

Description

Below is the explanation from the USAJOBS Team Titan Developers: The combo box is created via a script in the USWDS 2.0 and because of this, we are unable to address this item on our side. Someone will need to reach out to mention it to the team that created the design system.

The fix appears to be to have aria-controls added to the combo box input that's generated. The validation is that the this input must have both aria-expanded and aria-controls.

The following is the combo box input that has the 508 issue. There is an aria-expanded property, but not an aria-controls one.

Additional information [optional]

508 Invite User ATP - Updated.xlsx 508 Testing - Module - Invite User · Agency Talent Portal - 11-08.xlsx Module - Invite User · Agency Talent Portal - Confirmed Violations 13.docx

amyleadem commented 2 years ago

@Piglady64 Hello, I have updated the combobox script to build the input with an aria-controls attribute. Can you review the rendered code in this preview link and let me know if this meets expectations? Thanks!

Julie-Jackson commented 2 years ago

I had one of my developers look at this and he said it should fix the problem. Once it is implemented we will run another 508 test to make sure and let you know if it has resolved the issue.

Julie Jackson Agency Talent Portal Product Owner Office: 202-606-5230 Cell: 202-718-7608 @.**@.> | www.opm.gov/HRShttp://www.opm.gov/HRS [USAJOBS signature block]T

From: Amy Leadem @.> Sent: Thursday, January 27, 2022 12:47 PM To: uswds/uswds-site @.> Cc: Jackson, Julie A. @.>; Mention @.> Subject: Re: [uswds/uswds-site] 508 Error with Combo Box on USAJOBS (Issue #1359)

@Piglady64https://github.com/Piglady64 Hello, I have updated the combobox script to build the input with an aria-controls attribute. Can you review the rendered code in this preview linkhttps://federalist-3b6ba08e-0df4-44c9-ac73-6fc193b0e19c.app.cloud.gov/preview/uswds/uswds/al-combobox-508/components/detail/combo-box--default.html and let me know if this meets expectations? Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/uswds/uswds-site/issues/1359#issuecomment-1023486287, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADUL32QHWLNYU6HQ4DZVW5DUYGAKXANCNFSM5JE7MFLA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.**@.>>

mejiaj commented 2 years ago

PR available here →

thisisdano commented 2 years ago

Fixed in USWDS 2.13.2: https://github.com/uswds/uswds/releases/tag/v2.13.2