search

uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
183 stars 140 forks source link

USWDS-Site - Bug: banner header text, typo on Documentation site - incorrect info on Tutorial site #1968

Closed JJFranko closed 10 months ago

JJFranko commented 1 year ago

Describe the bug

On the Documentation site https://designsystem.digital.gov/, there are a couple of things that might need to be addressed.

  1. In the usa-bannerheader-text element, it references "An official..." whereas all your recent changes indicate that it should just be "Official" to avoid confusion between "An Official" and "Unofficial" `<p class="usa-bannerheader-text">An official website of the United States government`

  2. On the page https://designsystem.digital.gov/utilities/clearfix/, there is a typo under the "Utility mixins" section where the value under the "Utility" column is misspelled as "cleafix" (missing the "r")

On the Tutorial site https://github.com/uswds/uswds-tutorial, the final instruction says to Once the server is running, head to http://localhost:8080/ and follow the directions on the page! however, the command prompt - and even the tutorial instruction Part One, bullet 3 says Start up the tutorial site. This will serve the tutorial Jekyll site from the current terminal window. You can use a web browser to see the site at http://localhost:4000/. The correct port should be 4000.

Steps to reproduce the bug

Utilities clearfix typo is found on page: https://designsystem.digital.gov/utilities/clearfix/

Banner header text that needs correcting is on every header on site: https://designsystem.digital.gov/

Tutorial page with incorrect information is at: https://github.com/uswds/uswds-tutorial

Expected Behavior

No response

Screenshots

No response

System setup

No response

Additional context

No response

Code of Conduct

mejiaj commented 11 months ago

Possible related to https://github.com/uswds/uswds-site/issues/2226.

Assigning to me to look into adding clarity to the request. Things to confirm:

  1. What repo is involved or affected (opened on site, but mentions tutorial)?
  2. Is this is an issue with design system code/components?
  3. Confirm guidance portion of this
JJFranko commented 11 months ago

I may have mistakenly added this issue to the main USWDS repository rather than the USWDS Tutorial repo. It looks like the Tutorial repo had been updated along the way between download/install locally and returning to tutorial git site. See this set of commits https://github.com/uswds/uswds-tutorial/commit/5003744240ec4c5af18ad1519464206f14be897b#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 and you can see the changes where jekyll was removed and the instructions changed from localhost:4000 to localhost: 8080.

mejiaj commented 10 months ago

@JJFranko thanks for that note. I'm going to look at the banner on uswds-site, uswds-sandbox, and uswds-tutorial to make sure we're using the most up-to-date version of banner.

mejiaj commented 10 months ago

Closing this issue in favor of repo-specific issues. The following banners need updates: