uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
194 stars 146 forks source link

USWDS-Site - Bug: HTML Proofer failing on legacy link #1990

Closed jonathanbobel closed 1 year ago

jonathanbobel commented 1 year ago

Describe the bug

When trying to create a PR from a branch offmain, there is a failing step when running HTML proofer.

For the Links > External check, the following failures were found:

Steps to reproduce the bug

  1. Try to submit a PR against main
  2. Notice it fails on test_build at the HTML Proofer step

Expected Behavior

All external html links should be valid

Screenshots

Screen Shot 2023-01-30 at 11 25 05 AM

System setup

Additional context

proof bundle exec htmlproofer --allow-hash-href=true --enforce-https=false --allow-missing-href=true --ignore-empty-alt=true --ignore-status-codes 0,403,429,503,302 --swap-urls 'https\://designsystem.digital.gov/:/' --ignore-files "//select-a-language//,//2017//,//2018//,//2019//" ./_site

Running 3 checks (Scripts, Links, Images) in ["./_site"] on *.html files...

Checking 892 external links Checking 936 internal links Checking internal link hashes in 202 files Ran on 315 files!

For the Links > External check, the following failures were found:

HTML-Proofer found 1 failure!

Exited with code exit status 1

Code of Conduct

amyleadem commented 1 year ago

Transferring this issue to the uswds repo because the broken link is in WHO-IS-USING-USWDS.md.

amyleadem commented 1 year ago

Note: Moving this back over to uswds-site so that it can be combined with the effort to move the Showcase listing from uswds to uswds-site #3324.