search

uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
187 stars 141 forks source link

Disabled States: Phase 1 guidance rollout #2246

Open jaclinec opened 1 year ago

jaclinec commented 1 year ago

Phase 1 disabled states site content to update:

Steps required to complete this work

jaclinec commented 1 year ago

I created a draft of the guidance for those sections of the site and it is ready for content strategy to review, edit, and publish to the site.

brunerae commented 9 months ago

@brunerae and @sarah-sch to come back and breakdown this Issue

finekatie commented 9 months ago

Reviewed draft and made comments today. (12/1)

sarah-sch commented 9 months ago

12/13 discussed with Katie plan to align on text recommendations by end of week and pass on to team for review by 12/18.

finekatie commented 9 months ago

reviewed draft again after Sarah's work

sarah-sch commented 9 months ago

Will pass draft to Jacline and accessibility team week of 12/18.

sarah-sch commented 8 months ago

12/18 - Passed revisions to @jaclinec and also asked @amycole501 and @alex-hull to review only if they have time. Noting that the team has a lot of time-sensitive work ahead of the Jan. monthly call that is a higher priority right now.

jaclinec commented 8 months ago

I reviewed it and accepted most suggestions and added comments. It's shaping up really nicely!

sarah-sch commented 8 months ago

UX and accessibility reviewed content team's changes week of 12/18. Katie and Sarah giving text one more pass before handing off to fed team for review.

finekatie commented 8 months ago

Anne has been looking at this with us as of 12/27. Still one or two more queries to resolve.

finekatie commented 8 months ago

This is still in review and will move to next sprint, I suppose?

sarah-sch commented 8 months ago

@finekatie - Yes, let's move to the next sprint for review by federal team.

sarah-sch commented 7 months ago

Let's pick review back up with federal team next sprint. Cc @finekatie

finekatie commented 7 months ago

@sarah-sch and I discussed today and I took a quick peek. Would like Anne to revisit since there were comments after their last review. @annepetersen can you take a look?

annepetersen commented 7 months ago

Will start resolving changes to look at the cleanest closest-to-final copy now

annepetersen commented 7 months ago

Still a few queries to resolve in there, but it's looking good. Back to you, @sarah-sch and @finekatie.

Realizing that moving to FFR might have been premature, FWIW, but we're still figuring out the details there

sarah-sch commented 4 months ago

@annepetersen - picking this issue back up. I'm thinking it might most expeditious to lay the text out on our first guidance page (progress easily pattern) and get @thisisdano review on the PR. Does that plan work for the fed team? cc @finekatie and @jaclinec

(Posing this question in GitHub as well)

sarah-sch commented 4 months ago

Passing to @thisisdano for FFR on 5/1/2024

sarah-sch commented 3 months ago

Literature review had been approved by Dan. Slate review of website update copy by @thisisdano for sprint starting 5/2/2024.

thisisdano commented 3 months ago

Content approved. Moving back to In Progress to move it into production

finekatie commented 2 months ago

hi @brunerae , I'm revisiting. Looks like copy is ready to be added to the site now and I just need to do PRs to get the pages updated. Is that correct?

brunerae commented 2 months ago

Hey @finekatie - correct!!

finekatie commented 2 months ago

First PR created today for Progress Easily: https://github.com/uswds/uswds-site/pull/2744

I also asked team for guidance on where pieces of new content will live. Here's the request I sent today: Hey team, I am ready to work on PRs for adding the Disabled States content to the following pages: Complete a complex form - Progress easily pattern Form templates Form component I was not on the contract when all the initial discussions happened about this. I researched meeting notes but still need help with these things:

  1. For the Progress Easily content, am I adding the What to do and What not to do FIRST in the lists, or at the end of each?
  2. For Form templates, am I adding it first or last in the Accessibility guidance list?

  3. For Form component, the doc says "New section" Disabled states for components in forms" - Am I adding that section AFTER Accessibility guidance, or somewehere else on the page?

    I plan to create two other PRs for the other pages. Once I have guidance, I can complete the edits on the PRs and ask for review.

amycole501 commented 2 months ago

Any accessibility-related error messaging information should be added with the existing accessibility guidance.

Also: FWIW on the form template page, the guidance around required fields is also considered accessibility guidance. I'm not sure why it's in a separate section without a reference to accessibility.

In general: I suggest adding any relevant WCAG guidance links as references on these pages. The more we can tie in our recommendations to WCAG the better. For example: https://www.w3.org/WAI/WCAG22/Understanding/labels-or-instructions << that's related to required fields.

jaclinec commented 2 months ago

@finekatie:

1.Progress Easily content - Add at the end of the list 2.Form templates - Add at the end of the list

  1. Form component - Yes, let's add that section after Accessibility guidance

And I agree with Amy that we might want to rethink/discuss how we want organize content on both the form template and form component pages since disabled states and required fields guidance kinda fall under accessibility.

finekatie commented 2 months ago

@finekatie:

1.Progress Easily content - Add at the end of the list 2.Form templates - Add at the end of the list 3. Form component - Yes, let's add that section after Accessibility guidance

And I agree with Amy that we might want to rethink/discuss how we want organize content on both the form template and form component pages since disabled states and required fields guidance kinda fall under accessibility.

Question for @amycole501 and @jaclinec just to clarify: Does this mean I'm still going forward with these changes for now and then we're discussing a content reorg for the pages? Thank you for your patience!

amycole501 commented 2 months ago

Yes for now I think you can move forward; we can log this as something to come back to later. Thanks!

finekatie commented 1 month ago

PR #2744 (progress easily patten) is ready for review

finekatie commented 1 month ago

PR #2775 (form template) is ready for review

finekatie commented 1 month ago

PR: #2776 (form component)is ready for review.

finekatie commented 1 month ago

PRs approved internally but need changelog update resolution (two are using the same changelog and have different content: Form component and Form templates. This may be on hold until next week pending review with Dev team.

finekatie commented 2 weeks ago

Amy L added the changelog to the Progress Easily page and everyone has approved in general review. This is now with Dan for FFR.

Amy and Charlie and I discovered that content is publishing to both Form component and template page. Charlie combined the recommended content into the originally proposed Disabled states section and we are elminating ticket for changes to Form template page. This is in review.

finekatie commented 2 weeks ago

Both #2776 and #2744 are ready for FFR with @thisisdano

finekatie commented 2 days ago

In FFR with @thisisdano , just waiting for next steps. Amy Leadem may be reviewing changes in #2744