uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
187 stars 141 forks source link

USWDS-Site - Date Picker/Date Range Picker Guidance: Allow for manual entry #2294

Open mahoneycm opened 11 months ago

mahoneycm commented 11 months ago

Is your feature request related to a problem? Please describe.

Related to Usability Testing results.

User preference on entering dates: 2 prefer to type it in, one likes memorable date picker drop-downs

Describe the solution you'd like

Explicitly call out in our guidance that the component should always allow for the date to also be typed in manually. Provide language to that effect in Usability Guidance sections in both Date Picker and Date Range Picker components. Both offer calendar picker functionality.

Describe alternatives you've considered

No response

Additional context

This was originally intended for Date Picker. We discovered Date Range Picker also had similar functionality so we decided to add the same language on that component.

Code of Conduct

mejiaj commented 9 months ago

@jaclinec, @mahoneycm this looks ready to start, we just need help with writing up the guidance. If there's additional work required, please outline the tasks in the issue description.

CC @sarah-sch

annepetersen commented 2 weeks ago

In discussion, this seems like a quick win that should only require a content addition to the Usability section indicating that manual date entry should always be possible also. Content (with the assistance of UX), all yours! There are only two sentences in that section presently, so should be simple to integrate.

finekatie commented 2 weeks ago

Hi! Wondering if we should consider adding the same language to Date Range Picker as well?

In discussion, this seems like a quick win that should only require a content addition to the Usability section indicating that manual date entry should always be possible also. Content (with the assistance of UX), all yours! There are only two sentences in that section presently, so should be simple to integrate.

finekatie commented 2 weeks ago

Hi @mahoneycm and @annepetersen , I created a draft here. I'm not sure what other guidance we provide beyond advising manual date entry should be allowed. See what I wrote and have at it!

mahoneycm commented 2 weeks ago

@finekatie I added a potential suggestion to the draft. Let me know what you think!

jaclinec commented 1 week ago

@finekatie I commented on some of the content - just recommend tweaking a couple of words. Otherwise it LGTM! Also I agree we should add this guidance to date range picker.

finekatie commented 1 week ago

@finekatie I commented on some of the content - just recommend tweaking a couple of words. Otherwise it LGTM! Also I agree we should add this guidance to date range picker.

I like your tweaks and added them. If you approve of this version, mark yourself done in table at top of doc and I suppose a PR can be created to get it added. As for Date Range Picker - @mahoneycm do we need to do something specific to get this guidance added to that page? Like a new issue and PR, or make THIS Issue include it now?

jaclinec commented 1 week ago

My name isn't listed in the table and for some reason I can't figure out how to add it, but I approve! Thanks!

finekatie commented 1 week ago

My name isn't listed in the table and for some reason I can't figure out how to add it, but I approve! Thanks!

Oh no! I added you! I'll add the date you approved. Just need to check with @mahoneycm next about a PR for this and Date Range Picker.

mahoneycm commented 1 week ago

@finekatie I commented on some of the content - just recommend tweaking a couple of words. Otherwise it LGTM! Also I agree we should add this guidance to date range picker.

I like your tweaks and added them. If you approve of this version, mark yourself done in table at top of doc and I suppose a PR can be created to get it added. As for Date Range Picker - @mahoneycm do we need to do something specific to get this guidance added to that page? Like a new issue and PR, or make THIS Issue include it now?

My vote is to include it in this Issue/PR since we'd be adding the same piece of guidance to both pages!

finekatie commented 1 week ago

@finekatie I commented on some of the content - just recommend tweaking a couple of words. Otherwise it LGTM! Also I agree we should add this guidance to date range picker.

I like your tweaks and added them. If you approve of this version, mark yourself done in table at top of doc and I suppose a PR can be created to get it added. As for Date Range Picker - @mahoneycm do we need to do something specific to get this guidance added to that page? Like a new issue and PR, or make THIS Issue include it now?

My vote is to include it in this Issue/PR since we'd be adding the same piece of guidance to both pages!

Ok! I'll edit the Issue here to include it. What's next?

mahoneycm commented 1 week ago

Assigned to myself, @RachelCorsino, and @cathybaptista for whoever gets free first to add these updates to site this sprint!