uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
193 stars 147 forks source link

USWDS-Site - Bug: Remove mention of Alert dismissability #2425

Closed werdnanoslen closed 7 months ago

werdnanoslen commented 10 months ago

Describe the bug

The Alert page's usability guidance mentions Alerts should be dismissable.

Steps to reproduce the bug

https://github.com/uswds/uswds-site/blob/7943e666c36de06b0cf7190cb860d89b25eda4d2/_components/alert/guidance/usability.md?plain=1#L5

Expected Behavior

Should this be removed until there is guidance on how to do this, given it is not on the roadmap?

Screenshots

No response

System setup

No response

Additional context

No response

Code of Conduct

brunerae commented 9 months ago

Hi @werdnanoslen! Thanks for submitting this. We're going to explore making the Alert able to be dismissed (https://github.com/uswds/uswds/issues/5754) and, for now, we'll update our Guidance to add a note that we understand our guidance and current functionality don't align. We'll reference this Issue in that PR once its created.

sarah-sch commented 8 months ago

@finekatie - sharing a rough draft of this updated guidance for the Alert page

sarah-sch commented 8 months ago

Has been reviewed by @finekatie. Will send for fed final review on 3/13.

thisisdano commented 8 months ago

Approved copy, with an edit. Let's get it into production.

sarah-sch commented 8 months ago

@thisisdano and @finekatie, I left a final question for you in the document. Thanks for taking another look!

finekatie commented 7 months ago

I commented on 3/18. Still waiting for Dan's input.

sarah-sch commented 7 months ago

@brunerae asking @thisisdano for input 3/22/24 in FFR roundup. If dan can't look today, we will finalize copy with @annepetersen next week.

sarah-sch commented 7 months ago

Assigned @finekatie, @amyleadem, and @mahoneycm as reviewers on PR #2563.