uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
186 stars 140 forks source link

USWDS-Site - HTML Proofer: fix Performance Research broken link #2589

Closed mahoneycm closed 3 months ago

mahoneycm commented 4 months ago

Describe the bug

When testing HTML Proofer ignored codes, I found multiple broken links throughout the site.

Steps to reproduce the bug

Visit any of the following links which can be found on the respective USWDS pages:

[!NOTE] Showcase links resolved by #2586

Expected Behavior

Links should be updated or removed.

Screenshots

No response

System setup

No response

Additional context

I found this error after removing --ignore-status-codes 0. Unfortunately, some of the results were false positives, so we'll need to continue ignoring error code 0.

Code of Conduct

finekatie commented 4 months ago

Updating content on Performance-related pages is covered by #2542, so for this issue, I'm simply going to remove the link from the page.

finekatie commented 4 months ago

This will be closed by #2609

finekatie commented 4 months ago

After copy updates in PR, waiting for review from @sarah-sch and hoping to get ffr and merge after that.

finekatie commented 4 months ago

Sarah and Charlie approved. Added Dan and Anne for approval and added message in PR.

mejiaj commented 3 months ago

Closing as resolved.