search

uswds / uswds-site

USWDS website and documentation
https://designsystem.digital.gov
Other
183 stars 140 forks source link

USWDS - Remove pa11y tests from circleCI #2690

Closed amyleadem closed 2 weeks ago

amyleadem commented 1 month ago

Summary

Removed pa11y from circleCI.

[!Important] This PR should not be merged until we decide on an alternate method for testing accessibility on our site. This decision is outlined in #2303.

Related issue

Closes #2689

Part of #2303

Preview link

N/A

Problem statement

Pa11y should successfully run on every commit, but it now crashes almost every time. This means that:

  1. We are not getting effective accessibility scanning, and
  2. We cannot successfully build and merge our PRs

Solution

This PR removes the pa11y check from circleCI. We will explore other methods of automating accessibility testing as part of #2303.

[!Note] I also experimented with increasing the size of resource_class to xlarge but did not have any luck.

Testing and review

  1. Confirm the tests run without error
  2. Confirm that the correct code was removed
  3. Confirm that we have an alternative testing method set up
amyleadem commented 2 weeks ago

Closing because no longer needed. The pa11y tests were improved in #2699 and are no longer crashing.