uswds / uswds

The U.S. Web Design System helps the federal government build fast, accessible, mobile-friendly websites.
https://designsystem.digital.gov
Other
6.71k stars 921 forks source link

USWDS - Link: Update placement and allow for opt out #5942

Open mejiaj opened 1 month ago

mejiaj commented 1 month ago

Place label after link to follow W3C recommendation. Allow developers who have a custom implementation the option to easily remove label .

Originally suggested by @aduth in https://github.com/uswds/uswds/issues/5166#issuecomment-2137461653

brunerae commented 1 month ago

Passing this to the A11Y team (@amycole501 / @alex-hull ) to confirm if this is something you all think makes sense to pursue. Your action items:

After you've done the above, please update the Issue by:

If we want to pursue the work

If don't want to pursue the work

Thank you!

amycole501 commented 1 month ago

I agree that the "external link" or warning of opening in a new window needs to come after the link is announced to improve clarity. While the issue isn't a blocker for users, it is at least possibly confusing. Moving the announcement to the end of the link announcement will sound more like "Visit our website link name (link opens in a new window") which makes more sense to English speakers and users of English assistive tech.