search

uswds / uswds

The U.S. Web Design System helps the federal government build fast, accessible, mobile-friendly websites.
https://designsystem.digital.gov
Other
6.81k stars 932 forks source link

USWDS - Bug: Time picker instructions need more specificity to pass WCAG #6061

Open amycole501 opened 1 month ago

amycole501 commented 1 month ago

Describe the bug

The existing visible instructions for time picker aren't sufficient to prevent errors; we need to add clarity to the format and options to prevent users from typing in potentially invalid times. See https://www.w3.org/TR/WCAG20/#minimize-error-cues for clarification on 3.3.2

Steps to reproduce the bug

  1. Go to https://designsystem.digital.gov/components/time-picker/
  2. View hh:mm
  3. Try typing in 12:15
  4. Try typing in 19:30

Findings: hh:mm may not provide enough instructions for a user to select a valid time.

Expected Behavior

Suggest adding more clear instructions. For example:

Start typing or select an AM or PM time in half-hour increments.

Screenshots

No response

System setup

No response

Additional context

FYI there's a related issue here for adding a 24 hour option https://github.com/uswds/uswds/issues/4947

Code of Conduct

mejiaj commented 1 month ago

Removed Site from the issue title to avoid confusion.

amyleadem commented 1 week ago

Update

In a team discussion, we agreed to move forward with text that generally follows this structure: "Select a time from the dropdown. Type to filter options"