search

uswitch / binj

Clojure library for accessing the Bing Ads API
Eclipse Public License 1.0
0 stars 2 forks source link

upgrade to sdk 11.5.8.1. Major breaking changes to binj interface #4

Closed christianblunden closed 4 years ago

christianblunden commented 6 years ago

@pingles Not sure how you feel about this but I have upgrade to support v11.5.8.1 SDK

I've made some major breaking changes to binj, and added some notes in the README to spell this out. Auth and reports definitions are unchanged, just the mechanism of downloading and polling.

Wanted to simplify the process a lot and make use of the new ReportServiceManager that is in the SDK examples. I think there were too many public exposed function defn which I either deleted or made private.

I've tested this version in our production instance and it works fine. Also I'm not sure if the 0.3.0-SNAPSHOT in clojars has been tested? I didn't see how it could work as they have added version numbers to the report namespace.. I didn't try it though.

If you want to merge this then I'd like to bump version to 0.4.0 and release to clojars

christianblunden commented 6 years ago

Oh and this version now works in an uberjar :) see issue https://github.com/uswitch/binj/issues/2

christianblunden commented 6 years ago

I've also changed the project groupId so that it will now deploy to uswitch/binj clojars repo