search

uswitch / vault-creds

Sidecar container for requesting dynamic Vault database secrets
Apache License 2.0
84 stars 14 forks source link

.... tests? #24

Open aklinkert opened 5 years ago

aklinkert commented 5 years ago

Friends, are you seriously using this one in production without having a single f** test? 😅

Not sure how to handle this one tho. Who is in charge of this code at uSwitch?

pingles commented 5 years ago

Tests are one way to gain confidence. We have branches that contain refactorings (and tests to support those). If people would like to contribute code and gain confidence through adding tests we'd welcome them.

aklinkert commented 5 years ago

Thanks @pingles , sounds great. I'd like to implement #23 , what branch would be a good base to do so?