uswitch / vault-creds

Sidecar container for requesting dynamic Vault database secrets
Apache License 2.0
84 stars 14 forks source link

Add check for nil secret #33

Closed waiariki-koia closed 3 years ago

waiariki-koia commented 3 years ago

There was an error discovered where when trying to read the secret value, these were nil. Seen here

This means that both the error and secret were nil.

Looking in the vault code, there is a use case here where both the error and secret can be returned as nil.

This change should retry the actions if secret is nil