usyd-blockchain / vandal

Static program analysis framework for Ethereum smart contract bytecode.
BSD 3-Clause "New" or "Revised" License
161 stars 39 forks source link

Setuptools project conversion #36

Closed SamuelMarks closed 6 years ago

SamuelMarks commented 6 years ago

Before this gets too stale, I should send you a PR.

These new approaches seem to work:

python -m vandal.cli.disassemble -h
python -m vandal.cli.decompile -h

Whereas the version I was going for still needs a little work to support nargs properly:

python -m vandal -h

Want me to recreate these changes so it's ready to merge, or did you want to wait until that^ version is ready?

0xl3x1 commented 6 years ago

Thanks for your work on this! I think it would be nice to package the CLIs as command line scripts so that when the setuptools package is installed they are added to $PATH automatically and can be run directly without needing to do something like python -m vandal.cli.*

See http://python-packaging.readthedocs.io/en/latest/command-line-scripts.html

Is that something you could do?

SamuelMarks commented 6 years ago

Yeah of course I can do it like that. Just not sure if that's desirable.

Will take a look at the code again, and send you a quick PR [similar to current; but rebased] that has proper setuptools and all; then we can debate the dis/advantages of each approach in terms of binary executables.

Sound good?

[probably have a chance this weekend to do this]

0xl3x1 commented 6 years ago

That sounds great, thanks! :+1:

0xl3x1 commented 6 years ago

Closing due to inactivity