Possible bugs in MSISEInputs

ut-astria / orbdetpy

Orbit Determination with Python

https://ut-astria.github.io/orbdetpy

GNU General Public License v3.0

115 stars 38 forks source link

Closed mgrutten closed 5 years ago

mgrutten commented 5 years ago

I think there's a couple of bugs in the MSISEInputs java class.

Lines 86 and 96 should contain integer division by 3, not modulo 3 (i.e. just Integer.parseInt(p.substring(11, 13)) / 3)
Line 95 adds to apvals[i] without initialising it. It should be set to zero before the loop starting at line 90.

Shiva-Iyer commented 5 years ago

Mark, thank you for this catch! I doubt I'd have caught it any time soon. Please let me know if you come across other issues.