Open andreabringhurst opened 2 months ago
@cdemkegit Will you add the SQL for off the daily snap shot to this? @andreabr-dixie Will you coordinate this with Craig? We can probably do this is a separate pull-request.
@cdemkegit @andreabr-dixie I don't see the sql that we use to pull FTE off the daily snapshot.
@cdemkegit @andreabr-dixie I don't see the sql that we use to pull FTE off the daily snapshot.
@MattNickodemus It has it's own issue (#23 ) and is in the "no status" section of the project. It is not covered in this pull request.
@MattNickodemus based on your comments, it looks like we can move forward with this pull request, correct? I can see that this pull request is to merge to main. I would like to close this merge request and do a new pull request to the dev_branch, and reference this pull request. I would work with @cdemkegit to do this, so it doesn't interfere with his current work in merging the vignettes to the dev_branch. But once both this pull request and the vignette pull requests are on dev_branch, then he can move both of the changes to the main branch.
I think we are going to table this pull request to milestone: 2024 Q4
We talked about this in code review on 08/04/2024
@andreabringhurst @cdemkegit Where are we on this?
@MattNickodemus @cdemkegit Craig and I had planned to milestone this without these queries because it will require changes to the make_fte_function and the vignettes (which haven't been done yet).
We have pushed the milestone and this pull request will now be in the milestone. These are ready to go and have been approved at code review.
I added two more sql's to this pull request. I added fte_ipeds_12_month.sql and fte_ushe_annualized.sql.
@andreabringhurst It likes like we're still adding queries on this. Can you give me an update on what the status of this pull request is?
@MattNickodemus I am not adding anything else to this pull request. All sql's have been reviewed at code review. It is ready to be "pulled".
@cdemkegit @JoyBaule @CSPierce01 @mkhassan-isu @MattNickodemus Please review these again and approve the pull request.
When reporting FTE it is often reported in 3 ways, undergraduate fte, graduate fte and total fte. Writing 1 query for all 3 of these requests makes the most sense and means that there are less queries to manage in utDataStoR.
I added 3 new queries to fte_total_census, fte_total_current, and fte_total_end_of_term.
Adding a query for total fte that is for current, one for census and one for eot will mirror what exists with headcount in utDataStoR. There is a headcount_current, headcount_census and headcount_eot.
Add fte_total_census to utDataStoR to replace fte_gr_cred_hour_census and fte_ug_cred_hour_census have the new query report both ug, gr, and total fte by term and do it in only one query instead of two.
Add fte_total_eot to utDataStoR to replace fte_ug_cred_hour_eot have the new query report both ug, gr, and total fte by term and do it in only one query so that we don't need to create additional queries for gr and total.
Add fte_total_current to utDataStoR to replace fte_off_edify have the new query report both ug, gr, and total fte by term, have it use snapshot data and do not hard code terms. Correct the problems with fte_off_edify, it is pulling from the student level and not the course level like fte_total_current will.
This pull request will take care of issues #15 , #16 , and #17