ut-effectiveness / utDataStoR

https://ut-effectiveness.github.io/utDataStoR/
Other
0 stars 0 forks source link

FTE Enhancement - fte_total_census, fte_total_current, fte_total_end_of_term #22

Open andreabringhurst opened 2 months ago

andreabringhurst commented 2 months ago

When reporting FTE it is often reported in 3 ways, undergraduate fte, graduate fte and total fte. Writing 1 query for all 3 of these requests makes the most sense and means that there are less queries to manage in utDataStoR.

I added 3 new queries to fte_total_census, fte_total_current, and fte_total_end_of_term.

Adding a query for total fte that is for current, one for census and one for eot will mirror what exists with headcount in utDataStoR. There is a headcount_current, headcount_census and headcount_eot.

This pull request will take care of issues #15 , #16 , and #17

MattNickodemus commented 2 months ago

@cdemkegit Will you add the SQL for off the daily snap shot to this? @andreabr-dixie Will you coordinate this with Craig? We can probably do this is a separate pull-request.

MattNickodemus commented 1 month ago

@cdemkegit @andreabr-dixie I don't see the sql that we use to pull FTE off the daily snapshot.

andreabringhurst commented 1 month ago

@cdemkegit @andreabr-dixie I don't see the sql that we use to pull FTE off the daily snapshot.

@MattNickodemus It has it's own issue (#23 ) and is in the "no status" section of the project. It is not covered in this pull request.

andreabringhurst commented 1 month ago

@MattNickodemus based on your comments, it looks like we can move forward with this pull request, correct? I can see that this pull request is to merge to main. I would like to close this merge request and do a new pull request to the dev_branch, and reference this pull request. I would work with @cdemkegit to do this, so it doesn't interfere with his current work in merging the vignettes to the dev_branch. But once both this pull request and the vignette pull requests are on dev_branch, then he can move both of the changes to the main branch.

cdemkegit commented 1 month ago

I think we are going to table this pull request to milestone: 2024 Q4

We talked about this in code review on 08/04/2024

MattNickodemus commented 1 week ago

@andreabringhurst @cdemkegit Where are we on this?

andreabringhurst commented 1 week ago

@MattNickodemus @cdemkegit Craig and I had planned to milestone this without these queries because it will require changes to the make_fte_function and the vignettes (which haven't been done yet).

andreabringhurst commented 3 days ago

We have pushed the milestone and this pull request will now be in the milestone. These are ready to go and have been approved at code review.

andreabringhurst commented 2 days ago

I added two more sql's to this pull request. I added fte_ipeds_12_month.sql and fte_ushe_annualized.sql.

MattNickodemus commented 15 hours ago

@andreabringhurst It likes like we're still adding queries on this. Can you give me an update on what the status of this pull request is?

andreabringhurst commented 14 hours ago

@MattNickodemus I am not adding anything else to this pull request. All sql's have been reviewed at code review. It is ready to be "pulled".

andreabringhurst commented 8 hours ago

@cdemkegit @JoyBaule @CSPierce01 @mkhassan-isu @MattNickodemus Please review these again and approve the pull request.