Closed JoyBaule closed 1 month ago
@JoyBaule This is excellent work. How about we do this
@MattNickodemus @mkhassan-isu @cdemkegit @CSPierce01 please review and approve your vignette today (9/30/24).
@JoyBaule I like the changes, here are my suggestions on the Headcount Vignette Line 27 - Should be updated to use . . . number of days until the term starts . . . removing week number, days. Line 36 was changed from hardcoding the term to is_current_term. Please add a note that is_current_term will only work once the term starts, they can hardcode the term_id for headcount after registration starts. Line 44 - We use both the term and post-semester in the sentence. Can we update it to post-term since we use terms? Line 62, 113, 115 - Do we need to clarify it is the 15th day of instruction or change it to the 21st day of the term or end of third week? Line 72 Update the semester's end to term's end. Do we need to add the approved Banner headcount sql?
This was moved to #33 instead to test everything in the dev_branch first.
This pull request is to review the following formatting and styled vignettes and merge the vignettes into the utDataStoR package.
Each vignette has been styled with the prettydocs architect theme and embedded images.