ut-effectiveness / utDataStoR

https://ut-effectiveness.github.io/utDataStoR/
Other
0 stars 0 forks source link

Review Headcount SQL #8

Closed andreabringhurst closed 3 months ago

andreabringhurst commented 3 months ago
andreabringhurst commented 3 months ago

There are the following Headcount queries: headcount_census headcount_current headcount_end_of_term headcount_census_groups headcount_ipeds_12_month headcount_point_in_time

andreabringhurst commented 3 months ago

I reviewed the code last week (Aug. 12-16). I talked with Candi about if the code should be = TRUE or IS TRUE (both work the same). We both agreed that it needs to be there to help others on campus know that it is a boolean field - True or False. I want to bring the question to code review to see if we want to make a decision or want to say either works and not have a set rule.

andreabringhurst commented 3 months ago

I made a pull request #12 and discussed it with the team at morning huddle. We discussed it at code review yesterday (8/22/24) and all approved and we merged the pull request.