There is an issue where clang-format in CI cannot correctly identify the commit when a commit is added to a pull request, causing the clang-format check not to run. The workflow that checks clang-format relies on whether there is a diff to determine OK/NG. However, if clang-format fails to identify the commit, the CI passes even though clang-format did not run. This issue can be observed in the following example: https://github.com/ut-issl/s2e-core/actions/runs/9396464963/job/25877704595?pr=639#step:6:5.
Closing conditions
The issue should be resolved by fixing the clang-format check workflow to ensure that it correctly identifies commits and runs clang-format properly, preventing the CI from passing when clang-format has not been executed.
Details
There is an issue where clang-format in CI cannot correctly identify the commit when a commit is added to a pull request, causing the clang-format check not to run. The workflow that checks clang-format relies on whether there is a diff to determine OK/NG. However, if clang-format fails to identify the commit, the CI passes even though clang-format did not run. This issue can be observed in the following example: https://github.com/ut-issl/s2e-core/actions/runs/9396464963/job/25877704595?pr=639#step:6:5.
Closing conditions
The issue should be resolved by fixing the clang-format check workflow to ensure that it correctly identifies commits and runs clang-format properly, preventing the CI from passing when clang-format has not been executed.
Supplementary information
Note